Remove no-op cleanups as post-mono MIR opt #143208

Mark-Simulacrum · 2025-06-29T17:22:48Z

On cargo this cuts ~5% of the LLVM IR lines we generate (measured with -Cno-prepopulate-passes). Opening to assess performance.

Mark-Simulacrum · 2025-06-29T17:23:25Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-29T17:23:28Z

⌛ Trying commit e0423d5 with merge fb9de75…

To cancel the try build, run the command @bors2 try cancel.

Remove no-op cleanups as post-mono MIR opt On cargo this cuts ~5% of the LLVM IR lines we generate (measured with -Cno-prepopulate-passes). Opening to assess performance.

rust-bors · 2025-06-29T19:40:36Z

☀️ Try build successful (CI)
Build commit: fb9de75 (fb9de75a813ea747c43682b22929463ada3f80de, parent: 5e749eb66f93ee998145399fbdde337e57cd72ef)

rust-timer · 2025-06-29T22:01:34Z

Finished benchmarking commit (fb9de75): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	18.6%	[0.2%, 60.9%]	6
Regressions ❌ (secondary)	9.4%	[0.4%, 18.4%]	2
Improvements ✅ (primary)	-1.9%	[-3.8%, -0.2%]	18
Improvements ✅ (secondary)	-2.5%	[-17.6%, -0.2%]	21
All ❌✅ (primary)	3.2%	[-3.8%, 60.9%]	24

Max RSS (memory usage)

Results (primary 8.9%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	9.2%	[1.3%, 33.3%]	34
Regressions ❌ (secondary)	3.6%	[2.9%, 4.9%]	4
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	8.9%	[-1.6%, 33.3%]	35

Cycles

Results (primary 3.0%, secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	29.8%	[26.6%, 33.1%]	2
Regressions ❌ (secondary)	17.1%	[17.1%, 17.1%]	1
Improvements ✅ (primary)	-1.9%	[-3.0%, -1.2%]	11
Improvements ✅ (secondary)	-6.2%	[-20.2%, -2.1%]	8
All ❌✅ (primary)	3.0%	[-3.0%, 33.1%]	13

Binary size

Results (primary -0.7%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-0.7%	[-1.6%, -0.0%]	66
Improvements ✅ (secondary)	-0.9%	[-3.7%, -0.0%]	30
All ❌✅ (primary)	-0.7%	[-1.6%, -0.0%]	66

Bootstrap: 695.323s -> 698.39s (0.44%)
Artifact size: 371.80 MiB -> 371.90 MiB (0.03%)

On cargo this cuts ~5% of the LLVM IR lines we generate (measured with -Cno-prepopulate-passes).

Mark-Simulacrum · 2025-07-01T10:43:38Z

@bors2 try @rust-timer queue

rust-bors · 2025-07-01T10:43:40Z

Missing command.

Mark-Simulacrum · 2025-07-01T10:44:03Z

@bors2 try

rust-bors · 2025-07-01T10:44:07Z

⌛ Trying commit 676eed3 with merge e3a4b05…

To cancel the try build, run the command @bors2 try cancel.

Remove no-op cleanups as post-mono MIR opt On cargo this cuts ~5% of the LLVM IR lines we generate (measured with -Cno-prepopulate-passes). Opening to assess performance.

rust-bors · 2025-07-01T12:58:27Z

☀️ Try build successful (CI)
Build commit: e3a4b05 (e3a4b05fb719511c7b8d0306c3a9e0445abcdfda, parent: f46ce66fcc3d6058f90ac5bf0930f940f1e7b0ca)

rust-timer · 2025-07-01T15:56:56Z

Finished benchmarking commit (e3a4b05): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.0%	[-4.6%, -0.2%]	22
Improvements ✅ (secondary)	-2.8%	[-18.0%, -0.8%]	17
All ❌✅ (primary)	-1.9%	[-4.6%, 0.4%]	23

Max RSS (memory usage)

Results (primary -2.6%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-3.8%, -1.2%]	6
Improvements ✅ (secondary)	-1.3%	[-2.8%, -0.5%]	3
All ❌✅ (primary)	-2.6%	[-3.8%, -1.2%]	6

Cycles

Results (primary -2.4%, secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	3.2%	[0.8%, 7.1%]	4
Improvements ✅ (primary)	-2.6%	[-4.3%, -1.2%]	22
Improvements ✅ (secondary)	-5.0%	[-20.0%, -0.5%]	11
All ❌✅ (primary)	-2.4%	[-4.3%, 1.1%]	23

Binary size

Results (primary -0.6%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-1.4%, -0.0%]	66
Improvements ✅ (secondary)	-0.8%	[-3.6%, -0.0%]	30
All ❌✅ (primary)	-0.6%	[-1.4%, -0.0%]	66

Bootstrap: 461.485s -> 461.37s (-0.02%)
Artifact size: 372.20 MiB -> 371.78 MiB (-0.11%)

Mark-Simulacrum · 2025-07-01T16:15:15Z

@bors2 try jobs=x86_64-msvc

rust-bors · 2025-07-01T16:15:18Z

Unknown value for argument "jobs".

Mark-Simulacrum · 2025-07-01T16:15:27Z

@bors2 try jobs=*x86_64-msvc*

rust-bors · 2025-07-01T16:15:30Z

Unknown value for argument "jobs".

Mark-Simulacrum · 2025-07-01T16:16:35Z

@bors2 try jobs=x86_64-msvc*

rust-bors · 2025-07-01T16:16:38Z

Unknown value for argument "jobs".

Mark-Simulacrum · 2025-07-01T16:17:16Z

@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2

rust-bors · 2025-07-01T16:17:19Z

⌛ Trying commit 676eed3 with merge b84bb16…

To cancel the try build, run the command @bors2 try cancel.

Remove no-op cleanups as post-mono MIR opt On cargo this cuts ~5% of the LLVM IR lines we generate (measured with -Cno-prepopulate-passes). Opening to assess performance. try-job: x86_64-msvc-1 try-job: x86_64-msvc-2

rustbot · 2025-07-01T16:19:20Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-01T16:19:21Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

rust-bors · 2025-07-01T18:47:38Z

☀️ Try build successful (CI)
Build commit: b84bb16 (b84bb16650872972b9578b4aeeb3f78acd2d8912, parent: 076a0a26fd6f4c445647a33d6daaac56f732ac05)

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 29, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 29, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 29, 2025

Remove no-op cleanups as post-mono MIR opt

676eed3

On cargo this cuts ~5% of the LLVM IR lines we generate (measured with -Cno-prepopulate-passes).

Mark-Simulacrum force-pushed the skip-noop-cleanup branch from e0423d5 to 676eed3 Compare July 1, 2025 02:12

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2025

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Jul 1, 2025

Mark-Simulacrum marked this pull request as ready for review July 1, 2025 16:19

rustbot assigned petrochenkov Jul 1, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2025

Remove no-op cleanups as post-mono MIR opt #143208

Are you sure you want to change the base?

Remove no-op cleanups as post-mono MIR opt #143208

Conversation

Mark-Simulacrum commented Jun 29, 2025

Uh oh!

Mark-Simulacrum commented Jun 29, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 29, 2025

Uh oh!

rust-bors bot commented Jun 29, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 29, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Mark-Simulacrum commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 1, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

rustbot commented Jul 1, 2025

Uh oh!

rustbot commented Jul 1, 2025

Uh oh!

rust-bors bot commented Jul 1, 2025

Uh oh!

Uh oh!

Mark-Simulacrum commented Jul 1, 2025 •

edited

Loading